Skip to content

Fix how bundle IDs are getting defined for individual bundles#5342

Merged
antonis merged 4 commits intomainfrom
alwx/bugfix/serializer-fix
Nov 10, 2025
Merged

Fix how bundle IDs are getting defined for individual bundles#5342
antonis merged 4 commits intomainfrom
alwx/bugfix/serializer-fix

Conversation

@alwx
Copy link
Contributor

@alwx alwx commented Nov 6, 2025 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Fixes #5250

Here is the root cause:

  • Lazy-loaded chunks are serialized separately with their own preModules array
  • The debug ID module is only added to the main bundle's preModules
  • When processing a lazy chunk, determineDebugIdFromBundleSource() can't find the debug ID → returns null
  • The code throws an error instead of handling this gracefully

The solution is to generate bundle IDs for individual code chunks.
That needs to be done because when Metro 0.83.2 stopped importing BabelSourceMapSegment from @babel/generator and defined it locally, it subtly changed the source map output format.

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 394.62 ms 435.14 ms 40.52 ms
Size 43.94 MiB 48.82 MiB 4.88 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
eb07ba3+dirty 419.49 ms 482.12 ms 62.63 ms
2adbd1e+dirty 366.13 ms 419.49 ms 53.36 ms
276d348+dirty 356.30 ms 405.27 ms 48.97 ms
95aaf8a+dirty 342.82 ms 393.75 ms 50.93 ms
f234eb4+dirty 313.23 ms 333.31 ms 20.08 ms
2b89ce9+dirty 372.22 ms 417.06 ms 44.84 ms
c1573b3+dirty 355.65 ms 448.82 ms 93.17 ms
818a608+dirty 350.29 ms 397.38 ms 47.09 ms
6fee48d+dirty 370.23 ms 427.86 ms 57.63 ms
b7aa1aa+dirty 281.02 ms 317.53 ms 36.51 ms

App size

Revision Plain With Sentry Diff
eb07ba3+dirty 7.15 MiB 8.42 MiB 1.27 MiB
2adbd1e+dirty 7.15 MiB 8.43 MiB 1.28 MiB
276d348+dirty 7.15 MiB 8.42 MiB 1.26 MiB
95aaf8a+dirty 7.15 MiB 8.41 MiB 1.26 MiB
f234eb4+dirty 7.15 MiB 8.46 MiB 1.30 MiB
2b89ce9+dirty 7.15 MiB 8.41 MiB 1.26 MiB
c1573b3+dirty 7.15 MiB 8.42 MiB 1.27 MiB
818a608+dirty 7.15 MiB 8.41 MiB 1.26 MiB
6fee48d+dirty 7.15 MiB 8.41 MiB 1.26 MiB
b7aa1aa+dirty 7.15 MiB 8.46 MiB 1.31 MiB

Previous results on branch: alwx/bugfix/serializer-fix

Startup times

Revision Plain With Sentry Diff
d432f3d+dirty 373.82 ms 387.57 ms 13.76 ms

App size

Revision Plain With Sentry Diff
d432f3d+dirty 43.94 MiB 48.82 MiB 4.88 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 403.59 ms 422.00 ms 18.41 ms
Size 43.75 MiB 47.99 MiB 4.24 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
93137d1+dirty 400.15 ms 424.74 ms 24.59 ms
20d5eaa 377.62 ms 406.50 ms 28.88 ms
4167e15+dirty 344.77 ms 367.78 ms 23.01 ms
b7aa1aa+dirty 324.73 ms 327.76 ms 3.03 ms
1d62dde+dirty 409.00 ms 453.90 ms 44.90 ms
534ba8c 484.00 ms 499.93 ms 15.93 ms
6479fd5+dirty 412.95 ms 434.02 ms 21.07 ms
5ee3314+dirty 415.80 ms 426.14 ms 10.34 ms
1226664+dirty 347.45 ms 386.60 ms 39.15 ms
64cd15c 439.02 ms 427.63 ms -11.39 ms

App size

Revision Plain With Sentry Diff
93137d1+dirty 17.75 MiB 19.70 MiB 1.95 MiB
20d5eaa 17.75 MiB 20.15 MiB 2.41 MiB
4167e15+dirty 17.75 MiB 19.74 MiB 1.99 MiB
b7aa1aa+dirty 17.75 MiB 19.75 MiB 2.00 MiB
1d62dde+dirty 17.75 MiB 19.74 MiB 2.00 MiB
534ba8c 17.75 MiB 20.15 MiB 2.41 MiB
6479fd5+dirty 17.75 MiB 19.68 MiB 1.94 MiB
5ee3314+dirty 17.75 MiB 19.70 MiB 1.95 MiB
1226664+dirty 17.75 MiB 19.74 MiB 1.99 MiB
64cd15c 17.75 MiB 20.15 MiB 2.41 MiB

Previous results on branch: alwx/bugfix/serializer-fix

Startup times

Revision Plain With Sentry Diff
d432f3d+dirty 446.27 ms 438.84 ms -7.43 ms

App size

Revision Plain With Sentry Diff
d432f3d+dirty 43.75 MiB 47.99 MiB 4.24 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1204.15 ms 1206.00 ms 1.85 ms
Size 3.41 MiB 4.58 MiB 1.17 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
88890fe+dirty 1219.00 ms 1222.08 ms 3.08 ms
c7f264b+dirty 1229.78 ms 1225.84 ms -3.94 ms
c9e95bd+dirty 1205.83 ms 1207.38 ms 1.55 ms
64cd15c+dirty 1213.50 ms 1223.54 ms 10.04 ms
69602ce+dirty 1230.59 ms 1230.84 ms 0.24 ms
b3b5b0d+dirty 1235.16 ms 1238.61 ms 3.45 ms
1853710+dirty 1213.67 ms 1226.35 ms 12.67 ms
4a17c8f+dirty 1213.28 ms 1213.64 ms 0.36 ms
f70acbf+dirty 1239.00 ms 1242.53 ms 3.53 ms
5ee3314+dirty 1234.25 ms 1235.44 ms 1.19 ms

App size

Revision Plain With Sentry Diff
88890fe+dirty 3.19 MiB 4.57 MiB 1.38 MiB
c7f264b+dirty 3.19 MiB 4.48 MiB 1.29 MiB
c9e95bd+dirty 3.19 MiB 4.44 MiB 1.25 MiB
64cd15c+dirty 3.19 MiB 4.38 MiB 1.19 MiB
69602ce+dirty 3.19 MiB 4.48 MiB 1.29 MiB
b3b5b0d+dirty 3.19 MiB 4.48 MiB 1.29 MiB
1853710+dirty 3.19 MiB 4.48 MiB 1.29 MiB
4a17c8f+dirty 3.41 MiB 4.58 MiB 1.17 MiB
f70acbf+dirty 3.19 MiB 4.54 MiB 1.36 MiB
5ee3314+dirty 3.19 MiB 4.55 MiB 1.37 MiB

Previous results on branch: alwx/bugfix/serializer-fix

Startup times

Revision Plain With Sentry Diff
d432f3d+dirty 1193.77 ms 1194.71 ms 0.95 ms
fafa44d+dirty 1220.71 ms 1213.25 ms -7.46 ms

App size

Revision Plain With Sentry Diff
d432f3d+dirty 3.41 MiB 4.58 MiB 1.17 MiB
fafa44d+dirty 3.41 MiB 4.58 MiB 1.17 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1225.00 ms 1226.29 ms 1.29 ms
Size 3.41 MiB 4.58 MiB 1.17 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
88890fe+dirty 1219.20 ms 1231.00 ms 11.80 ms
c7f264b+dirty 1211.82 ms 1218.04 ms 6.22 ms
c9e95bd+dirty 1240.19 ms 1246.33 ms 6.14 ms
64cd15c+dirty 1216.31 ms 1214.04 ms -2.26 ms
69602ce+dirty 1235.65 ms 1230.82 ms -4.83 ms
b3b5b0d+dirty 1227.71 ms 1239.50 ms 11.79 ms
1853710+dirty 1224.35 ms 1230.18 ms 5.84 ms
4a17c8f+dirty 1226.36 ms 1219.28 ms -7.07 ms
f70acbf+dirty 1235.71 ms 1243.14 ms 7.43 ms
5ee3314+dirty 1215.18 ms 1207.64 ms -7.54 ms

App size

Revision Plain With Sentry Diff
88890fe+dirty 2.63 MiB 4.00 MiB 1.37 MiB
c7f264b+dirty 2.63 MiB 3.91 MiB 1.28 MiB
c9e95bd+dirty 2.63 MiB 3.87 MiB 1.24 MiB
64cd15c+dirty 2.63 MiB 3.81 MiB 1.18 MiB
69602ce+dirty 2.63 MiB 3.91 MiB 1.28 MiB
b3b5b0d+dirty 2.63 MiB 3.91 MiB 1.28 MiB
1853710+dirty 2.63 MiB 3.91 MiB 1.28 MiB
4a17c8f+dirty 3.41 MiB 4.58 MiB 1.17 MiB
f70acbf+dirty 2.63 MiB 3.98 MiB 1.34 MiB
5ee3314+dirty 2.63 MiB 3.99 MiB 1.35 MiB

Previous results on branch: alwx/bugfix/serializer-fix

Startup times

Revision Plain With Sentry Diff
d432f3d+dirty 1219.17 ms 1209.83 ms -9.34 ms
fafa44d+dirty 1224.29 ms 1223.96 ms -0.34 ms

App size

Revision Plain With Sentry Diff
d432f3d+dirty 3.41 MiB 4.58 MiB 1.17 MiB
fafa44d+dirty 3.41 MiB 4.58 MiB 1.17 MiB

@alwx alwx marked this pull request as ready for review November 7, 2025 08:47
@alwx alwx self-assigned this Nov 7, 2025
antonis
antonis reviewed Nov 7, 2025
View reviewed changes
antonis
antonis reviewed Nov 7, 2025
View reviewed changes
antonis
antonis approved these changes Nov 7, 2025
View reviewed changes
Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work identifying and fixing this @alwx 🎸
The fallback approach looks solid to me. Added a couple of questions but overall LGTM.

antonis
antonis reviewed Nov 7, 2025
View reviewed changes
CHANGELOG.md
### Fixes

- Android SDK not being disabled when `options.enabled` is set to `false` ([#5334](https://github.com/getsentry/sentry-react-native/pull/5334))
- Fixes how bundle IDs are getting defined for individual bundles ([#5342](https://github.com/getsentry/sentry-react-native/pull/5342))
Copy link
Contributor

@antonis antonis Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add a reference to 0.83.2+ here

@alwx alwx added the ready-to-merge Triggers the full CI test suite label Nov 10, 2025
@antonis
Copy link
Contributor

antonis commented Nov 10, 2025

I'll proceed with merging since the failing tests are not relevant with this PR:

@antonis antonis merged commit 72fc84a into main Nov 10, 2025
85 of 92 checks passed
@antonis antonis deleted the alwx/bugfix/serializer-fix branch November 10, 2025 15:53
@alwx alwx mentioned this pull request Nov 17, 2025
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonis antonis antonis approved these changes

@lucas-zimerman lucas-zimerman Awaiting requested review from lucas-zimerman lucas-zimerman is a code owner

Assignees

@alwx alwx

Labels

ready-to-merge Triggers the full CI test suite

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[react native 0.82.0] Debug ID was not found in the bundle. Call options.sentryBundleCallback if you are using a custom serializer.

3 participants

@alwx @antonis @lucas-zimerman